Tarjeta Qr

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • The width: 100% property for section element is not necessary. because it's s a block level element which will take the full width of the page by default. So remove width.

  ---

  • Use min-height: 100vh for section instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the section will have 100vh height no matter what. Even if the content spans more than 100vh.

  ---

  • But if we set min-height: 100vh then the section will start at 100vh, if the content pushes the section beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  IRVINE MESA•1,855

  @DrMESAZIMPosted over 1 year ago

  welldone I do have one suggestion which I want you to consider is to put some border radius properties on your image

  if you find this difficult to do let me know and I can do youtube video for you editing your code

  0