Tarjeta de vista previa con uso de Media

Community feedback

• 

  Adriano•38,270

  @AdrianoEscarabotePosted about 1 month ago

  Hi Brandon Jr Cortez, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:

  Consider using rem for font size .If your web content font sizes are set in absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. Relative units “stretch” according to the screen size and/or user’s preferred font size, and work on a large range of devices.

  if you want to continue coding with px, you can download a very useful extension in vscode, it converts px to rem!

  link -> px to rem

  A document ought to have one primary landmark, and the absence of a main tag around the page's primary content is the root of this issue. On this page, there is no other element that is more important than the one that this challenge is based on, so to solve it, wrap all the content in the'main' tag.

  It's always a good idea to pay close attention to the proper use of semantic html elements because they are crucial for screen reader users to understand what the main content of the page is in the case of the'main' tag!

  The rest is amazing.

  I hope this is helpful. 👍

  Marked as helpful

  0

  ---

  

  Brandon Jr Cortez•170

  @BrandonJr20Posted 29 days ago

  @AdrianoEscarabote Muchisimas gracias, omiti el uso de etiquetas semanticas, y la extension que me brindaste espero usarla proximamente.

  1
• 

  FirstHalcyon•90

  @FirstHalcyonPosted about 1 month ago

  Hey, Brandon, good work, keep it up.

  Good job with the box shadow and the border radii, they're spot on. In the future, I'd suggest playing around a bit more with the measurements to get them to look more similar to the design wanted. Look up em vs rem to get a good gist of what they are and how they work.

  Marked as helpful

  0

  ---

  

  Brandon Jr Cortez•170

  @BrandonJr20Posted about 1 month ago

  Muchas gracias @FirstHalcyon !

  1