Design comparison
SolutionDesign
Solution retrospective
Tarjeta realizada a base html y css vainilla
Community feedback
- @AgusSaMacPosted over 2 years ago
Hello Ivan congratulations on completing the challenge!
I noted some things on your solution:
- Be mindful of your reports. you have a couple of issues there.
- You used two massive media queries, it would have been better if you wrote your code for mobile outside the query and just use the media query to expand to the other design.
- On the same line, instead of one big media query, break it in several small chunks. It will be easier to mantain that way as your code grows larger.
- You forgot give the proper
font-family
to the prices, and make smaller the original price. - The image is not centered on the desktop view. Just change your with in the card-sec-one from 40% to 50%. that should take care of that problem.
- For the issue with the button on that same view, remove the
margin-left
and change yourwidth=100%
formin-width=80%
Hope it helps,
Keep it up and happy coding!
Have a great day!
Marked as helpful0@ivan2214Posted over 2 years ago@AgusSaMac Hello AgusSaMac, thank you very much for your contribution to my solution. Now I am going to try to solve the problems that you told me about. Cheers!
0@AgusSaMacPosted over 2 years ago@ivan2214 That's great Ivan, I'm glad to be of help.
Have a great day!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord