Design comparison
Solution retrospective
I changed a couple of things. The hover states just zoom in instead of changing colors and have some opacity. I added some slight animations, and also the landing page svg was giving me a bit of a hard time I believe it is because of the way I laid out the sections. The hardest part of the project was the SVG's and positioning them correctly which I believe I still did not do well. Overall fun project probably will do another one just for fun. Theres also a slight bug where if the user opens to modal on a screen width smaller than md and then expands the screen the styling is stuck. Ill probably look more into this. Any feed back is appreciated thanks guys
Community feedback
- @Finney06Posted over 1 year ago
Hello there 👋. Good job on completing the challenge !
Here are some suggestions regarding your code that may be of interest to you.
HTML 🏷️:
To clear the Accessibility report:
-
Wrap the page's whole main content in the
<main>tag. -
Use HTML5 semantic elements such as
<header>,<nav>,<main>,<aside>, and<footer>to define these sections. -
Use ARIA landmarks such as
<header role="banner">and<footer role="contentinfo">to provide additional information about the purpose of each section to assistive technologies.
Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.
I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!
0 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord