Skip to content
Submitted over 1 year ago

QR code component | TailwindCSS

kofi astr0•190
@Kofiastro
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I had difficulties maintaining the same dimension on mobile and Desktop since i was using flexbox.

Community feedback

  • Sonsawan Ngamsom•140
    @murphy6867Posted over 1 year ago

    I have a few suggest for you. First of all semantic HTML, I think first <div> tag after <body> it's should be <main> tag and last <div> should become <footer>. It's help for accessible. Second thing is container of content and media query of screen you should style of mobile first and next to large screen, i found a lot of error about responsive design. I hope my suggestion is helpful :D.

    Marked as helpful
    1
    kofi astr0•190
    @KofiastroPosted over 1 year ago

    @murphy6867 thank you.I am working on it

    0
  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    QR iMAGE ALT TEXT 📸:

    • Since this component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute.
    • The alt attribute should explain the purpose of the image.
    • E.g. alt="QR code to frontendmentor.io"
    <img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    kofi astr0•190
    @KofiastroPosted over 1 year ago

    @0xAbdulKhalid Well Noted and thank you .i'm working on it.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord