@pritxxh
Posted
Utilize CSS Flexbox or Grid for more flexible and responsive layout options.
Implement lazy loading for images to improve initial page load times.
Incorporate ARIA (Accessible Rich Internet Applications) attributes to enhance accessibility for screen reader users.
Consider integrating a content delivery network (CDN) for improved website performance and global accessibility.
@VaalGeek
Posted
@pritxxh Thanks a lot for your advise, I shall do that, except the Flexbox and Grid, my solution utilizes them. Unless there's something I am missing. But thanks for an insightful comment.
@VaalGeek this is bad/redundant feedback.
the comment on using flexbox/grid should tell you pritxxh didn't actually review your code. you did perfectly fine in this regard.
you should not lazy load images which are visible right away (called above the fold) and even if you did, it would not improve performence in this case. more info: to-lazyload-above-the-fold-images
your solution doesn't need any aria tags as it is already accessible. more aria tags does not mean it's better or more accessible.
since you are using vercel you don't need an additional cdn because vercel and in fact github.io is a cdn and it is not adviced to add a cdn on top of a cdn.
vercel.com/guides/why-running-another-cdn-on-top-of-vercel-is-not-recommended
side note: if you look at pritxxh's solution you'll see that their solution still has issues and doesn't implement any of his own feedback.
Marked as helpful
@VaalGeek
Posted
@meelix Thanks a million buddy. And I shall be following you from now on.
@fastcheetah
Posted
Just about to launch mine you check some stuff about why the width of the anchor tag is off give me 5mins@VaalGeek
@fastcheetah
Posted
Sir, try not to put a height let your element determine the height of the container@VaalGeek
@fastcheetah
Posted
done @VaalGeek
