Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Tailwind QR code component

@MRK4

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@Samdevtechnology

Posted

Hello there 👋. Congratulations on job well done! 🎉 🎉 🎉

  • I would like to make some suggestions concerning your code that might be of help.

HTML 🏷️:

  • This solution generates accessibility error report: "All page content should be contained by landmarks". This is due to a non-semantic markup, which causes a lack of landmark for a webpage.
  • So fix this by replacing the <div class="p-4 flex ..."> element with the semantic element <main> along with <div class="... attribution"> into a <footer> element in your index.html file.
  • What is meant by landmark ?: They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers. We make use of sematic elements to provide landmarks to our webpage example includes <main>, <aside>, <footer>, etc., instead of relying on generic elements like <div> or <span>.
  • Every webpage should contain one <main> element and it should include all content directly related to the page's main idea, there should only be one per webpage.

Well done for completing this challenge 👍

I hope have been of help, Please feel free to ask any question

Happy Coding 🎉

1

@MRK4

Posted

@Samdevtechnology Thanks for the help ! I'll improve the component asap :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord