Skip to content
Submitted 9 months ago

Tailwind CSS, Flexbox, Javascript

John Pugh•340
@JohnPugh688
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Easybank landing page
  • HTML
  • CSS
  • JS
3intermediate

Design comparison

SolutionDesign

Solution retrospective

This is my first project using Javascript. I hope you can take the time to have a look at my code and give me some feedback as like i've mentioned before this is all new to me. Ive spent the past 10 years working as a construction site manager with very little experience even using a computer. So for me this is a huge challenge that i'm enjoying more than i ever expected. I think on my next project i'm going to give React a go as i think this will work really well along with tailwind CSS? Anyone else use this combination let me know your thoughts and any tips for setting up my coding environment would be welcome. As always i look forward to you feedback good or bad. thanks in advance

Community feedback

  • BrunoMoleta•700
    @brunomoletaPosted 9 months ago

    "Hola" John,

    I advise you to avoid styling the `````body```` tag. Things may get unnecessarily messy doing so.

    For starter, the body ought to have a width:100% and then, inside the header, main and ````````footertag you may use adivwith the.max-w-[1440px]````.

    Also, I don't see the need to use a section inside the header tag. You can use an a,nav and button, because the header is the section, you know?

    Another observation: The article card will lead the user to another webpage, so this shall not be a div tag, for divs have no semantic meaning.

    It's better if this tag is an article. According to MDN: The <article> HTML element represents a self-contained composition in a document, page, application, or site, which may be independently reusable. Examples include a forum post, a magazine or newspaper article, or a blog entry

    Also, I recommend this blog: JoshComeau. He writes thoroughly about front-end programming. It's worth checking from time to time.

    (If you find this comment helpful, please mark it as helpful)

    Congrats on the effort, John :)

    Best regards from Brazil

    Marked as helpful
    0
    John Pugh•340
    @JohnPugh688Posted 9 months ago

    @brunomoleta Thanks for your feedback. I struggle to get the grasp of semantic html. Understanding when to use different tags will hopefully come with experience. What you have recommended makes complete sense now I look at it so thanks for taking the time to have a look at my coding. Much appreciated 👍

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord