@kristinakasalova
Posted
Hi Athar,
nice job, looks good on desktop, despite some changes that could improve it.
I'd recommend to use more of semantic HTML tags, e.g. you use class ="main"
while there ismain
tag available as default.
Additionally, a few more div
tags could be used as containers for lists or blocks of text. That would allow you to style a bit better, for example use the same padding/margin within the main column and among the blocks themselves. At the moment, some blocks are offset as per design, others are not which doesn't look neat.
The lists' font color is incorrect, but that's a minor one.
What I think is a quite big issue is missing media queries, so lacking responsiveness on mobile. Looking at your page on smaller screen is a problem. This is something I think you need to revise or add (or at least think about in your future projects), as responsive pages are standard nowadays.
To sum it up, you did good to complete the challange, but need to focus on responsive design next time.