table hr

Community feedback

• 

  kristinakasalova•90

  @kristinakasalovaPosted 4 months ago

  Hi Athar,

  nice job, looks good on desktop, despite some changes that could improve it.

  I'd recommend to use more of semantic HTML tags, e.g. you use class ="main" while there ismain tag available as default.

  Additionally, a few more div tags could be used as containers for lists or blocks of text. That would allow you to style a bit better, for example use the same padding/margin within the main column and among the blocks themselves. At the moment, some blocks are offset as per design, others are not which doesn't look neat.

  The lists' font color is incorrect, but that's a minor one.

  What I think is a quite big issue is missing media queries, so lacking responsiveness on mobile. Looking at your page on smaller screen is a problem. This is something I think you need to revise or add (or at least think about in your future projects), as responsive pages are standard nowadays.

  To sum it up, you did good to complete the challange, but need to focus on responsive design next time.

  0
• 

  John Paul Tropa•40

  @Paul-wackdevPosted 4 months ago

  It seems that the HTML file doesn't include any semantic elements I suggest to study more about semantic HTML to improve the code more, viewing the page on my screen it looks very big it does not seem like it is responsive I suggest looking at your page from a smartphone or just a smaller screen the design is not structured

  0