Tabbed Interface, Vanilla JS, & SASS

Community feedback

• 

  P

  DalaScript•530

  @DalaScriptPosted 5 months ago

  Hey👋, Good Job!

  Your Project looks very good and most importantly it is functional and works

  I'm kind a perfectionist Person, And I'll give you some tips to improve your design.

  • your image in <figcaption class="profile"> container needs outline property instead of border, and image's sizes will match.
  • <h1>Jeremy Robson</h1> needs line-height: 47px
  • you need hover for your <div class="content"></div> container.
  • you need also hover for your ellipses image, it should be actually button, And on hover it should change color :

  <button class="card-btn">
     <svg width="21" height="5" xmlns="http://www.w3.org/2000/svg">
        <path d="M2.5 0a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5Zm8 0a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5Zm8 0a2.5 2.5 0 1 1 0 5 2.5 2.5 0 0 1 0-5Z" fill="#BBC0FF" fill-rule="evenodd"/>
     </svg
  </button>
  

  and then to change color of those ellipses (I saw your using scss, so I will write for scss):

  button {
     &:hover {
        path {
           fill: **here comes what color you want**;
        }
     }
  }
  

  Good Luck! 🍀

  Nika.Dala

  Marked as helpful

  0

  ---

  

  P

  Nate Valline•420

  @nvallinePosted 5 months ago

  Hi @NikaDalalishvili ,

  Thanks for the feedback! I didn't know about using outline instead of border to get the desired result like the design.

  The rest were very helpful as well, I mainly just forgot/missed some of the hover effects.

  I have implemented your feedback and updated my solution.

  Thanks again!

  1

  

  P

  DalaScript•530

  @DalaScriptPosted 5 months ago

  @nvalline With pleasure! 😊 Thank you so much for such a kind assessment. 🌟 Good luck! 🍀✨

  0