Sveltekit + Transition with TailwindCSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hey there, Wahyu Syamsul A'lam! 👋

  Nice job on this challenge! 👏 Your solution looks great and works very well! 🙌

  One things I'd like to suggest is to set the alt text for the images in this challenge to an empty string so that they will be ignored by screen readers. That's because those images aren't really necessary or important for the content of the page and do not need to be read by screen readers.

  As for separating things into components, this is a very small project, so it's not a big deal if you have a couple of large components that comprise the whole site. When you work on bigger projects however, you'll want to separate lots of things down into components (basically, anything you can reuse elsewhere or just large files that need to be broken down). So, like the card container, the submit button, and the ratings section could all be different components that you can use across a large site. 😉

  Hope you find these suggestions helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1

  ---

  

  Wahyu Syamsul A'lam•30

  @wahyusaPosted over 2 years ago

  @ApplePieGiraffe thank you for this feedback I've just got new insight about this alt tag I should update it next time.

  I agree with component it should be based on the project size except that was required by our client XD we should make it simpler in 1 file.

  1
• 

  Daniel Leite•30

  @DanielvermelPosted over 2 years ago

  Hi Wahyu!

  If next time you struggle with Github Pages I suggest you to use Vercel since it's more straightforward and you can deploy your project in 2 min.

  Regarding your solution, in my opinion, you should have 2 components (Rating, Thank-You) since it makes not only the project more readable but also easier to reuse the components if needed too.

  Marked as helpful

  0

  ---

  

  Wahyu Syamsul A'lam•30

  @wahyusaPosted over 2 years ago

  @Danielvermel yup, vercel is also a great place but for I will use ghpages since I already know how to deploy it 😁 but maybe in some cases I should use vercel.

  So, we should use multiple component to increase readability and of course reusable component for multiple use especially on large project like mentioned by @ApplePieGiraffe

  Thank you for your feedback

  0