Design comparison
Solution retrospective
I made some missteps at the start and some bad component architecture but I was able to do some research and restructure the components. I'm proud that I solved the currency conversion from numbers without installing a library and that I passed props across multiple components including functions. I would do more architecture testing up front instead of jumping in.
What challenges did you encounter, and how did you overcome them?Lots of changes to get the components and props to work together. A good change in one components broke something in another component a couple of times but I worked through these issues.
What specific areas of your project would you like help with?Passing props and using functions as props.
Community feedback
- @blacdavPosted 3 months ago
Great work, but svelte, and react??? How??
Marked as helpful0 - @wendyhamelPosted 2 months ago
Hi,
I like the add item animation in the cart. It is subtile and intuitive!
Your design looks good, but it doesn't quite match the design on desktop size. Your card images are rectangular and in the design they are square. Your layout could use some padding on the top and bottom on all screen sizes so users know they reached the end of the page. Now you try to scroll down because it looks like there may be some more content below.
You could improve the semantics of your project if you use HTML elements like
<section>and<article>. It helps browsers organising the accessibility tree. Screen readers can walk trough your project better so their users can navigate and process the information. see MDN docsI can't help you with advise about passing props and using functions as props in react unfortunately. I do not work with react.
Happy coding!
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord