Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

sunnyside-agency-landing-page-main using HTML, CSS and JQuery

@himanshukrmr

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Community feedback

Lukasz 160

@lukaasz555

Posted

Good job Himanshu, I like that you used semantic HTML (header, nav, footer). Clickable header is also good feature, but there is a still some features that you can improve, e.g.

  • you haven't done a view for mobile (good practice is to work mobile-first), I mean that your hamburger is not showing when I am resizing window;

  • LEARN MORE shoud be a clickable element (redirection isn't important at the moment) so you should use <a> or <button> instead of <h2>;

  • when I am resizing divs .five and .six I am loosing text;

  • ul.about & ul.media: it's similar to learn more. You should use <a> or <button> instead of <li>, of course, you can wrap e.g. <a> inside <li>;

  • the color of footer is wrong:P

Keep coding:-)

Marked as helpful

0

@himanshukrmr

Posted

@lukaasz555 Thanks! for the feedback, will work on the points you have suggested. And for mobile view I have done only for 375px right now.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord