Design comparison
Solution retrospective
Any feedback is welcome !
Community feedback
- @pikapikamartPosted almost 3 years ago
Hey, great work on this one. Desktop layout looks fine, hero-section is just too tall that's why the content are pushed down on the screenshot. Site is responsive but the breakpoint of 1000px for mobile state is too big for the whole mobile view to occupy. Desktop layout could use more of those. Mobile state looks great , though the each person's name on the testimonial section have their position besides their name which should not be and should be instead placed in another row.
Some other suggestions would be:
- The
.attribution
should be inside thefooter
so that it will be inside a landmark element. - On this one, the
header
could beabsolute
withwidth: 100%
so that the content will not be pushed down. - Remember that a website-logo is one of the meaningful images on a site so use proper
alt
for it. Use the website's name as the value likealt="sunnyside"
. - Reduce usage of
section
tag since they don't give any information when navigated as landmark unless they are being labelled byaria-labelledby
. You can replace them withdiv
since the heading tags are enough to describe each section. - Add an extra
aria-hidden="true"
attribute on theimg
that is usingalt=""
so that the image will be completely hidden for screen-reader users. - Those
learn more
in desktop state should be placed on the left side and not being centered. - For each testimonial card, you can use this markup so that it will be easier for users to navigate on it:
<figure> <img src="" alt={person name}> <blockquote> <p> {qoute in here}</p> </blockquote> <figcaption> person name <p> person role </p> </figcaption> </figure>
- Person's image should be using the person's name as the
alt
value likealt="Emily R"
. Components like this where a person's information is presented, make sure to use their name as the person'simg
alt
value. - The person's name and the person's position are two separate text so don't use a single text element to wrap them.
FOOTER
- Those 3 links after the logo could be inside a
nav
since those are still your website's navigational links. Just add anaria-label="footer"
on thisnav
so that it will be unique. - Those social-media links could be inside a
ul
element since those are "list" of links. - Each
a
tag that wraps the social-media icon should have eitheraria-label
attribute orsr-only
text inside it, defining where the link would take them. For example, you should usefacebook
as the value if the link would take the user to facebook.
MOBILE
- Hamburger menu should be using a
button
since it is an interactive component.
SUPPOSING BUTTON IS USED
- The hamburger
button
should have a default attribute ofaria-expanded="false"
and it will be set totrue
when the users toggles it and vice-versa. - The hamburger
button
should have eitheraria-label
attribute orsr-only
text inside it which defines what thebutton
does. You could usearia-label="navigation dropdown menu"
- The
img
inside the hamburger-menu should have been hidden since it is only a decorative image. - The dropdown is not being hidden properly. Using only
opacity
andtransform
hides them visually but not internally like what it should be. Add an extravisibility: visible
on the hidden state of the dropdown and usevisibility: visible
on the visible state. This way, it will be hidden properly.
Aside from those, great job again on this one.
Marked as helpful0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord