Skip to content
Submitted about 2 years ago

Sunnyside-Agency-Landing-Page

Rico•370
@Shuliii
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Agency landing page
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

I didn't really have any issues in particular doing this. I guess it means I have improved? XD

any feedbacks are always welcome

Community feedback

  • Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    Hi Rico, how are you?

    I really liked the result of your project, but I have some tips that I think you will enjoy:

    • images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.
    • We have to make sure that all the content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    The rest is great!

    I hope it helps... 👍

    Marked as helpful
    0
    Rico•370
    @ShuliiiPosted about 2 years ago

    @AdrianoEscarabote actually i don't really quite understand.

    so instead of using "<header></header>" we should use "<div role='header'></div>" instead?

    0
    Adriano•38,120
    @AdrianoEscarabotePosted about 2 years ago

    @Shuliii no, prefer to use html5 semantic elements but if you want you can use aria too

    0
    Rico•370
    @ShuliiiPosted about 2 years ago

    @AdrianoEscarabote ahh, but did I use the html5 semantic elements wrongly?

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord