Alexandra• 550
@Alexandra2888
Posted
Hi! Congrats for finishing challenge! Your solution is very close to the design! Here are some things i think you can improve:
- implement semantic HTML,
- make CSS reset: *, *::after, *::before {margin:0; padding:0: box-sizing: border-box;};
- try to use either classes or ids,
- choose better names for classes or implement BEM naming convention. It will be easier in bigger projects and when you will work with other developers,
- convert px into relative units (em/rem). Px are usually used when coding for magazines/newspapers and you need fix units. Happy coding!
Marked as helpful
0
