Sunnyside Landing Page using SASS/SCSS

Community feedback

• 

  Guilherme Fernandes Vidotti•520

  @VidottizzzPosted over 1 year ago

  Hello, congratz for your solution! I really liked, the ideia of changing color of the navbar when scrolling down, and when i open the hamburger menu options, and stretch the page, the hamburger goes away as expected but the menu continues there, so i think just turning its display to none as you did with the hamburger can solve this. Nice job , and keep practicing!

  Marked as helpful

  0

  ---

  

  Priskin Zsuzsanna•320

  @PriskinZsuzsannaPosted over 1 year ago

  @Vidottizzz

  Thanks Guilherme!

  You are absolutely right. I completely missed it, and update as soon as possible.

  Thanks a lot!!!

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  ANCHOR ELEMENT 🔴:

  • The <a> elements lacks aria-describedby attribute which is way more important for social links in an <a> tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.

  ---

  • When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an aria-describedby attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.

  ---

  • By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.

  ---

  • Example:

  <a href="#" aria-label="Facebook profile of Sunnyside">
      <svg class="icon" width="20" height="20" 
        xmlns="http://www.w3.org/2000/svg"></svg>
  </a>
  

  ---

  • If you have any questions or need further clarification, you can always check out my submission for another challenge where i used this method and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Priskin Zsuzsanna•320

  @PriskinZsuzsannaPosted over 1 year ago

  @0xAbdulKhalid

  Dear Abdul!

  Thank You so much! You're right. I definetally should use aria atrributs. I will look into them, and thanks for your time, and help!

  Happy coding to You as well!

  0