SunnySide landing page using HTML, CSS and basic JS for navigation

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted about 3 years ago

  So far so good. Well done.

  • use semantic html wherever possible. Using a div to do the work of a button will require you to add aria attributes so that assistive technology will be able to identify the hamburger as a button

  <div class="burger">
            <div class="line-1"></div>
            <div class="line-2"></div>
            <div class="line-3"></div>
          </div>
  

  • responsive images techniques (srcset and picture element) are part of responsive design and are considered best practice for displaying right image content for different devices. Using css to hide a desktop image when on mobile and vice-versa works but is considered expensive, wasting bandwidth and increases the loading time of a page

  Looking good on my mobile phone

  0