Design comparison
Solution retrospective
I actually was planning to practice JS but end up most of this is just CSS but nvm ... any feedback would be greatly appreciated 😆
Thankyou
Community feedback
- @fidellimPosted about 3 years ago
Hi Adeline,
Great work on this project! Looks great for both desktop and mobile views. Just some suggestions I would like to share :
- You can change the width of your project container to 100% instead. This will remove the scroll bar on the x-axis.
- Don't forget to put the hamburger icon back to its original state when you press it again. It still remains to be tilted even after pressing it several times.
I hope it helps :)
Marked as helpful1@adelinejunePosted about 3 years ago@fidellim Hi, Thankyou very much for the suggestion !
1 - @Carlos-A-PPosted about 3 years ago
Hello
This looks pretty great and good job! I do have a wide monitor and I would suggest setting the "graphic design" and "photography " as a div with background images instead of inserting the image in your HTML. That way you don't have to use absolute positioning on your text and make the element responsive on bigger screens too.
1@adelinejunePosted about 3 years ago@Carlos-A-P Thankyou for your suggestion I have already change to display grid so now it can fill the whole screen :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord