Sunnyside Landing Page || CSS HTML JS

Community feedback

• 

  Magda•235

  @magdaszszPosted over 3 years ago

  For inline svgs I usually do svg path { fill: color}

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @magdaszsz thank you Magda, knowing that help me out in another challenge that i just started

  0
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hi there, Luis Colina! 👋

  Good job on this challenge! 👏 Your solution looks very nice and I really like the animations you added to the content of the page and the mobile menu! 😀

  One small thing I'd like to suggest is adding overflow-x: hidden to the body to prevent a horizontal scroll bar from appearing along the bottom of the page when some of the animations play.

  Also, a little padding around the text of the reviews near the bottom of the page would be nice so that the text isn't right up against the edge of the screen in the mobile layout. 😉

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @ApplePieGiraffe thanks applePie

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Well it looks good 2 things I noticed

  1. the mobile menu when open drops down pretty far away from the hamburger button

  2. the ground of 4 images near the footer are not square shaped in mobile view at 375px wide browser

  But great job on this challenge

  1

  ---

  

  Luis Colina•1,043

  @Comet466Posted over 3 years ago

  @palgramming hello patrick i already fixed the hamburger menu and the 4 ground images looked really stretched cause of a way too big min-height property that was set, thanks for pointing out those flaws

  0