Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Sunnyside landing page built using Sass and Vanilla Javascript

P
Andrija 510

@andrijaivkovic

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback would be appreciated. Thanks! :)

Community feedback

T
ApplePieGiraffe 30,545

@ApplePieGiraffe

Posted

Hello, Andrija! 👋

Well done on this challenge! 👍 Your solution looks great and responds nicely! 👏

Just one or two things I suggest are,

  • Using a button element for the mobile menu button in the mobile view of the site in order to make your solution more accessible.
  • Setting the alt text for the social media icons in the footer of the page to an empty string so that they are ignored by screen readers (since they aren't necessarily important to the content of the page). It would be better to add some screen reader-only text inside those links or add an `aria-label` attribute to them instead to make sure they can be identified by screen readers.

Hope this helps. 😊

Keep coding (and happy coding, too)! 😁

Marked as helpful

2

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord