Submitted over 2 years ago
Sunnyside landing page built using Sass and Vanilla Javascript
@andrijaivkovic
Design comparison
SolutionDesign
Solution retrospective
Any feedback would be appreciated. Thanks! :)
Community feedback
- @ApplePieGiraffePosted over 2 years ago
Hello, Andrija! 👋
Well done on this challenge! 👍 Your solution looks great and responds nicely! 👏
Just one or two things I suggest are,
- Using a
button
element for the mobile menu button in the mobile view of the site in order to make your solution more accessible. - Setting the
alt
text for the social media icons in the footer of the page to an empty string so that they are ignored by screen readers (since they aren't necessarily important to the content of the page). It would be better to add some screen reader-only text inside those links or add an `aria-label` attribute to them instead to make sure they can be identified by screen readers.
Hope this helps. 😊
Keep coding (and happy coding, too)! 😁
Marked as helpful2 - Using a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord