Sunnyside landing page

Community feedback

• 

  P

  j5•2,290

  @jmnyaregaPosted over 3 years ago

  Great work on the challenge @Adekola, my recommendations:

  • At around 863px(window width), the images on the gallery component are stretched out to fit their containers, this happens immediately after desktop to mobile transition. To prevent this behaviour, you can use object-fit: cover on the images.

  • You can use Grid or flex layout on the image gallery. You won't need a clear fix. These layouts were created to fix such hacks. 🙂

  • Semantically, client testimonials should be a list of items.

  0
• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Looking nice on mobile. Here are a few suggestions :

  • do not skip heading levels. The first one should be an h1 then next should be an h2, h3 etc in that order.
  • alt values should be descriptive to help assistive technology users visualize the message that is being put across and must be unique, 3 images having the same alt value is not that beneficial to the intended users. Decorative images can have an empty alt value.

  0