Design comparison
SolutionDesign
Solution retrospective
Phew! Took a while to find out that index.html is the viewable name to host a page. Anyway, here's my submission for the sunnyside webpage. Let me know what you think. Thanks.
Community feedback
- @adityaphasuPosted over 1 year ago
Hey there!
Your solution looks nice!!
π― There's some semantic errors though that should be corrected:
- You dont need a h1 heading for the screen readers because this challenge's H1 is actually the text "WE ARE CREATIVES". It should be like this:
<h1 class="bigtext">WE ARE CREATIVES</h1>
- The subsequent big texts in the section "Transform your brand" and "Stand out to the right audience" are actually h2s rather than h3s. They should be like this:
<h2>Transform your brand</h2> <h2>Stand out to the right audience</h2>
- In the testimonial section the text "Client Testimonials" as you have named the class, it's a heading so you should replace the
div
tag with ah2
tag. One more thing is that you shouldnt use uppercase words in the HTML instead use CSS to modify the text like this:
.testimonial-heading{ text-transform: uppercase; }
Read more about it Here!.
The solution is good but with semantic HTML it would be perfect! You can read more about the importance of semantics here.
Happy coding!πΊπ»
Marked as helpful1 - @victorebegbunaPosted over 1 year ago
Lovely solution. Just needed some alignment adjustment.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord