Sunnyside (HTML, CSS, JS)

Community feedback

• 

  Ren Ras•420

  @renrasPosted almost 3 years ago

  I noticed that you added an event listener to resize. Be careful with this as it actually keeps on running and might affect the performance of your site. With background image, you can change the url using media queries instead. Make your resize event listener run fewer times as needed by event throttling etc. Also, you can look into using a resize observer instead. Images also have a srcset property which you can use. It automatically chooses the optimal image depending on screen size.(Though I never really figured out how to make it work.)

  Marked as helpful

  0

  ---

  

  Khizar Saeed•40

  @KhizarSaPosted almost 3 years ago

  @renras Thanks for the feedback it is really helpful

  0
• 

  Rémi Martineau•355

  @MartineauRemiPosted almost 3 years ago

  Hey ! You did a great work, and your solution is looking good ! You should wrap your social media icons with <li> tags in your footer section. Happy coding :)

  Marked as helpful

  0

  ---

  

  Khizar Saeed•40

  @KhizarSaPosted almost 3 years ago

  @MartineauRemi will do thnx for the feedback

  0