Sunnyside Agency using HTML5 , CSS3 , JavaScript and Bootstrap 5

Community feedback

• 

  George Mushore•310

  @tenderkingPosted about 2 years ago

  hei, your mobile version the images are strecthing weirdly, I also see you have a display none !important. avoid important in css. the reason you have it it's because you have display: inline-block !important. you have double images one for desktop and another for mobile you can either do like you did without the important, or as background images or use which i recommend html picture to toggle between two images https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture i have'nt checked your code just the preview site p.s some of the font sizes and colors are wrong.

  1

  ---

  

  Milos Djordjevic•990

  @milosshomyPosted about 2 years ago

  @tenderking Hey , I am using Bootstrap classes that's why you can see !important. It is because I am switching images based on screen size. The challenge gave 2 images , 1 for desktop 1 for mobile so I just use them. For font size and colors, I don't have premium account so I can't see design in Figma so it can't be pixel perfect. Thank you for feedback!

  0

  

  George Mushore•310

  @tenderkingPosted about 2 years ago

  @milosshomy hmm. if you use picture its pure html, no need for bootstrap or css to switch between two images. yeah understand about the design. it looks good in my opinion. You did a great job.

  1