@Guille-Sanchez
Posted
In a quick look, the website looks awesome. I noticed you'd used vanilla JavaScript, which is pretty wild but since the challenge is a static site, it is all right. For challenges which are dynamic, for example posting comments, I would recommend you to try a library like React or framework like Vue. You can totally do those challenges with vanilla JS, which has its own merit, but it may be a little bit discouraging to do so, since it tends to be much more difficult.
Having said that, your repo seems well organized. The only comment I would give you is to separate the code from index.html into more files, and import them in index.html. Your code right now has 291 lines, which may be difficult to debug/update in the future. I am not well verse in vanilla, but I think there must be a way to do so by using it.
Marked as helpful
@TryinghardFE
Posted
@Guille-Sanchez Thank you. I have little knowledge of Javascript. Basically, I did copy-paste a few things from other resources and tweak the classes a little.
Will take note of your advice. Planning to start learning Vanilla Javascript this quarter and hopefully I get to pick up React or Vue soon.
@Guille-Sanchez
Posted
@TryinghardFE Vanilla JS is a little bit difficult. It is good to start learning with it though because it cements the knowledge used in each framework/library without depending on any of them. After solving exercises like tic-tac-toe/ rock-papers-scissors I would recommend you to start diving into frameworks. Do not rush, just try to learn a lit bit every day. Consistency makes a good programmer. And about the copy-paste, that's all right. But try and understand what you copy-and-paste and do not do it blindly.
Marked as helpful
