Sunnyside Agency Landing Page using Sass, Vanilla JavaScript

Community feedback

• 

  P

  Emmilie Estabillo•5,540

  @emestabilloPosted over 3 years ago

  Hey Carlos, looks good! Here are a few points:

  • You typically would need only one set of top nav instead of two. Adjust the styling of the menu to adapt to your breakpoints rather than duplicating html.

  • Instead of using divs, the links on the nav and footer can be list items inside ul tags, like ul > li > a.

  • The text inside .photo-design-container should be on the bottom part of the div like on the screenshot, but for some reason the live link has the text in the opposite direction. Not sure if you pushed code last-minute but justify-content: flex-end should sort it.

  Hope this helps!

  Marked as helpful

  1
• 

  Yakub•260

  @Yakub-EgamnazarovPosted over 3 years ago

  Hi Carlos, congrats on the completion of the project, and here is few comments from my side.

  1. on the learn more it is been used div element for the line, I think it is ok with that, but in my opinion, it would be better if you used ::before or ::after pseudo-element, and manipulate its opacity, rather than just scaling up the entire btn-div-wrapper, however, you can ignore that.
  2. in the graphic design section, the tex-block seems misaligned vertically, I think it is better to adjust by margin or padding.

  Overall, it seems the solid solution. Good job, keep coding, cheers

  Marked as helpful

  0