sunnyside agency landing page using JS and AOS

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  • since the following code is supposed to be a button, but you choose to use a div, there is no functionalities to allow assistive technology users to be able to identify it as such. Find more on what wai-aria attributes you need to add .

    <div class="hamburger-menu">
          <img src="images/icon-hamburger.svg" alt="menu" class="menu-icon">
        </div>
  

  • Find out more on responsive image techniques , the method you used in your code works but is not among the best practices. Recommended methods include srcset and picture element.

   <div class="about-item about-img-1" data-aos="fade-up"
      data-aos-offset="200"
      data-aos-delay="50"
      data-aos-duration="1000"
      >
        <img src="images/mobile/image-transform.jpg" alt="about image" class="mobile-img">
        <img src="images/desktop/image-transform.jpg" alt="about image" class="desktop-img">
      </div>
  

  • i would prefer the animation on the arrow to have a set time such that it stops after a few seconds. Continued animation can be disturbing to other users
  • otherwise well done with the progress so far. It is responsive and close to the design

  Marked as helpful

  0