Design comparison
Solution retrospective
any feedback is welcomed :)
Community feedback
- @brodiewebdtPosted almost 3 years ago
You did a great job on this. Looks really good. You want to wrap all of your content in a Main tag. You just have one section named main. Add aria-label="Facebook link" etc.. to the A tag surrounding your font-awesome links. Add Alt text to your two testimonial images. They can stay empty as they are decoration only.
Download AXE DevTools and you can clear accessibility warnings while you code. https://www.deque.com/axe/devtools/
Hope this helps.
Marked as helpful0@vanzasetiaPosted almost 3 years ago@brodiewebdt There's no need to put the word "link" as long as it has been wrapped with an anchor tag. The same logic applies to the alternative text on
img
.Marked as helpful1@Vj3koPosted almost 3 years ago@brodiewebdt totally forgot to wrap all content in MAIN tag, tnx for reminding me tho, also nice addon to have ( AXE devtools). I installed it, it's quite helpfull.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord