Rajaul Islam Ratul• 1,250
@ratul0407
Posted
@Wael-Orraby congratulations on completing this challenge🎉🎉
The solution looks pretty good. But you should consider improvising it a little bit,
- When I was viewing your solution, even though I was on my pc the site was displayed as mobile version. Because you have set a media of
(min-width: 1440px)and viewport was 1280px. In the design files the they mentioned that desktop site is 1440px but it's a good practice to implement desktop sites on 1024 to 1200px . - There is a white space coming up on the right side on the screens for mobile and desktop you might consider checking it.
I hope it was helpful for you 👍👍
Happy coding brother🙂🙂
Marked as helpful
1
Wael Orraby• 370
@Wael-Orraby
Posted
@ratul0407 Thank you for your comments, brother. I will pay more attention to the computer view next time and will also investigate where the white space is coming from. Thanks again.
1
