Sunnyside agency landing page

Community feedback

• 

  Manuel Fernando Gallego Arias•120

  @mgallegoaPosted about 2 years ago

  Hi @dhdbrud318,

  Great job with this challenge!!!! loved the sticky menu :)

  Here are some points to consider for improvement, hope help to learn:

  1. I notice a little diference between the designd and the result, exist a lot of tools to solve this. I use the chrome extension PerfectPixel by WellDoneCode if you like to take a look.
  2. For the naming of the stiles you can use a standard. I use BEM convention (https://en.bem.info/methodology/css/) just for CSS.
  3. For accessibility the links should be work with an anchor <a>, there are a lot of user that just navigate in the pages with the keyboard.
  4. The accessibility issues reported for the front end mentor, could be solved adding a <h2> sub title and hide it with CSS display: none. This allow to some screen reader to direct the user in the section or article.

  Marked as helpful

  0