Sunnyside Agency landing page

Community feedback

• 

  Arne•1,110

  @DudeldupsPosted 9 months ago

  Hello! 👾

  Let me give you some tips on how to improve your solution.

  You are setting your font-sizes in px while you should do it in rem or - if you know what you're doing - in em. This way, if a user has set a custom font size in their browser, the font on your page will adjust accordingly. If you use px, the font size is static.

  When you need uppercase letters, do not do this in your HTML. Use CSS to make them uppercase. Most screen readers would pronounce the letters one-by-one and this would be confusing.

  Most of the time, there's no need to set a fixed height on elements. If you give the elements some padding you can just let them take the space they need. This also simplifies making the site responsive.

  In your HTML, your site is missing a <main> element and for the footer you need to use the semantic element <footer>.

  The headings always need to be in descending order. Every website needs one h1, the next sub-headings are h2 and the ones below h3 and so on. If you have two sibling sections, both would have an h2 as title.

  When citing people's testimonials or similar, you should use the <blockquote> element.

  If your images do not add any meaning for the website, the alt tag can be empty, but for everything else you should always provide meaningful alt text.

  A <menu> element is the same as a <ul> and should always have <li> as direct children.

  On several screen sizes, your site has a horizontal scroll bar. This is because you set fixed widths on elements. This is the same as the fixed height, if you just let the element take up the space it needs, you should always get away to use a max-width.

  I can see you didn't get any feedback on your previous solutions. One good way to still learn something, is look at other ppl's solutions for the same challenge that get feedback. And the good thing is, that the beginner challenges have plenty of submissions each day here 🙂

  I would advise you to do some more easy challenges and maybe tackle the new learning paths that have just been introduced here on Frontend Mentor 🤠

  Hope this helps, maybe come back later to this challenge and do it again or go ahead and try to implement the changes to adjust the solution 🙂

  Happy coding!

  Marked as helpful

  1

  ---

  

  Renish Okago•220

  @fabrizia2Posted 9 months ago

  @Dudeldups Thanks for the review, made the suggested changes.

  0