Submitted over 3 years ago
Sunnyside agency landing page made with Html Scss Js
@Amine-El-Alouani
Design comparison
SolutionDesign
Solution retrospective
any feedback would be great :)
Community feedback
- @ChamuMutezvaPosted over 3 years ago
- consider using semantic elements where possible. Elements like nav, main , header, footer etc instead of divs. Some of the errors listed in the report can be fixed by having a
main
element. - You nav-link should have an
a
element as a child of theli
. They are links that are supposed to be directing to another page or section. - i would not have 2 navigation (mobile and desktop navigation) - that can be done with css to position them accordingly
- headings must progress in order starting with h1, h2, h3 etc. Do not skip the headings
Marked as helpful0@Amine-El-AlouaniPosted over 3 years ago@ChamuMutezva Thank you so much for your advice it's helpful :)
0 - consider using semantic elements where possible. Elements like nav, main , header, footer etc instead of divs. Some of the errors listed in the report can be fixed by having a
- @afrusselPosted over 3 years ago
Nice work. If possible then add a close icon after click hamburger menu to close
Marked as helpful0@Amine-El-AlouaniPosted over 3 years ago@afrussel Thank you so much I'll fix it :)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord