Design comparison
SolutionDesign
Solution retrospective
Looking on opinion about the navigation menu if I there's a better way to do it.
Community feedback
- @eklemisPosted almost 3 years ago
Hi Nanc,
Congratulation for working so far with the challenge. Keep coding and keep making progress!
For your navigation, i see that little triangle on on mobile screen. That one is a bit tricky but you made it. Good job! Some notes:
- The cursor for anchor must be pointer to urge user that the element is meant to be clickable. The top menu must have the same behaviour as the menu on the bottom
- All menu item should have the hover states to help user see them as clickable element
- On mobile screen, the burger button image must be changed to 'x' icon after user display the menu so the have clear idea how to close the opened menu. You can do that by change the
srcvalue of theimgelement on your#hamburgerclick event as addition to what you already write there.
That's all for now, hope you understand my comment!
Marked as helpful0 - @anoshaahmedPosted almost 3 years ago
To get rid of the accessibility/HTML issues shown in your Report:
- wrap everything in your body in
<main>... OR use semantic tags ... OR giverole=""to the direct children of your<body>... Click here to read more <section>and<article>usually need a heading; so if you don't need a heading in it, use some other element such as<div><a>should have anaria-label... Click here to read more
Read your Report for more information.
Great job! :)
0 - wrap everything in your body in
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord