Sunnyside agency landing page

Community feedback

• 

  Finney•3,030

  @Finney06Posted over 1 year ago

  Hello there 👋. Good job on completing the challenge !

  Here are some suggestions regarding your code that may be of interest to you.

  HTML 🏷️:

  To clear the Accessibility report:

  The error message "ul and ol must only directly contain li, script, or template elements" typically appears when there is invalid HTML markup in the code. This error indicates that either an <ul> or <ol> element contains an element other than <li>, , or <template> elements as direct children.

  • If you need to include other types of elements within a list, you can nest them within an <li> element.

  • Use a validator tool to check your HTML code for other possible errors.

  Here's an example of valid HTML markup for an ordered list:

  <ol>
    <li>Item 1</li>
    <li>Item 2</li>
    <li>Item 3</li>
  </ol>
  

  And here's an example of valid HTML markup for an unordered list:

  <ul>
    <li>Item 1</li>
    <li>Item 2</li>
    <li>Item 3</li>
  </ul>
  

  By ensuring that your HTML markup follows the specifications, you can avoid errors and ensure that your web page is accessible to all users.

  • The error message "All page content should be contained by landmarks" typically appears when the HTML code does not contain the necessary accessibility landmarks to help users navigate the content of the page. In this case, the <div> element with class "attribution" is not a landmark or a footer element, and therefore it does not provide any navigation aid for users.

  To fix this error, you can do the following:

  • Use HTML5 landmarks: HTML5 introduced several new elements that can be used to define the different sections of a web page, such as <header>, <nav>, <main>, <aside>, and <footer>. By using these elements, you can create a clear hierarchy of content that is easy to navigate for users.

  Here is a web accessibility evaluation tool📕 to check your webpage for any remaining errors or warnings related to landmarks.

  I hope you find it helpful!😏 Above all, the solution you submitted is 👌. 🎉Happy coding!

  Marked as helpful

  1

  ---

  

  Mario Christofell•180

  @mariotbg11Posted over 1 year ago

  @Finney06 Thank you so much for the feedback 😊👍🏻

  0