Submitted over 3 years ago
Sunnyside agency Landing page - HTML, SCSS and JS
@hudarashid
Design comparison
SolutionDesign
Solution retrospective
Hi all,
Struggling to get this done, mainly on the hero section. Any feedback is welcome 🙂
Community feedback
- @ChamuMutezvaPosted over 3 years ago
Managed to check the site on my mobile, the presentation is good. There are a few recommendations I am listing below :
- A site should have a heading, the main heading should be an
h1
element and then the headings should ascend without skipping other headings. - use semantic html eg the div with the class
title
should be anh1
- The purpose of the hamburger is to open and close the modal navigation, in my opinion it should be a button not an anchor element.
- alt values have to be descriptive for the benefit of assistive technology users.
- for the links use an unordered list as well. A list will help assistive technology users know how many elements they are supposed to tab through and the current position of the tab
Marked as helpful0 - A site should have a heading, the main heading should be an
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord