Sunnyside Agency Landing Page (HTML | SCSS | JS Vanilla)

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 2 years ago

  Hi

  Is there a reason you've deviated from the design on the call-to-action links? You would not be able to do that in a real job and have introduced accessibility failures by doing so.

  0

  ---

  

  T

  Grace•31,270

  @grace-snowPosted almost 2 years ago

  Some other feedback

  • header is a distinct landmark and cannot go inside a section
  • the nav toggle button must come directly before the content it's toggling in the DOM order. This is an important part of any disclosure pattern so the next element is what's been Toggled
  • a h1 should not really be in a header as that landmark is meant to hold content that repeats on every page of a site. But I can see why you've done it in this case because of the design. It's just not ideal. Either way a header cannot go in a section as it will lose its banner semantics for some assistive tevhnologies
  • never write words like "image" in alt text. It is already an image
  • for decorative images alt should be blank. For meaningful images the alt should properly describe what the image looks like
  • learn more links should be links (anchor elements) not buttons. These elements have district purposes and in this case clicking them would trigger navigation
  • graphic design and photography should not be h3s unless they "belong" to the preceeding h2 content or have a visually hidden h2 before them in that section
  • same with testimonials. That should definitely be a h2 not h4. Heading order is important and should communicate the structure of the documents content
  • the blockquote and client info should ALL be inside the figure element, with the client info as the figcaption
  • social link labels should only say the name of the social platform with no extraneous words "link to our.."

  I hope this is helpful

  0

  

  Krutagna Patel•390

  @krutagna10Posted over 1 year ago

  @grace-snow Thanks for the feedback I will improve code as suggested

  0