Design comparison
Solution retrospective
Css has always been my weak point. This project really helped me to grasp the frontend concepts after a few failures.
Community feedback
- @legion40216Posted over 1 year ago
Good job on this challange, i would like to point some improvement
1.remove the
width
property of 1150px instead let the flex streach and shrink accourding to the size of the view port for better responsiveness on testmoninal-box and add property offlex-wrap
towrap
2.I liked your implementation of
margin: 28em auto
in.text-service
i was trying myself to find another solution by doing it without usingpostion: absolute
and good use of custom classes3.You should add
background-position: center
in yourservice section
images withbackground-repeat: no-repeat
this will inhance responsiveness4.You should reduces the padding of the left and right of
text-about
classes using calc or min max properties for responsiveness using vw or vh unitsOverall well done loved the detailed thought you put on it
1@brokenShinobiPosted over 1 year ago@legion40216 really appreciate that you took some time to point out my mistakes and also how I can improve them. The site has some issues while displaying in small screens and I'm looking into fixing them. Being mostly a backend guy, css is very new to me so I'm taking baby steps. Thanks again Suleman :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord