Sunnyside agency landing page built with CSS and JavaScript

Community feedback

• 

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  Great work 👍, but I have a suggestion for you!

  • Remove background-size: 100% 100% from class .hero and add these styles instead

  background-size: cover;
  background-position: center;
  

  like this background image will fit well on all devices!

  0

  ---

  

  Bibiwei Pere•490

  @Bibiwei-PerePosted over 1 year ago

  @lack21 Thanks for the feedback, but I don't think that's really necessary. I opted for background-size: 100% 100% because it covers the 2 line of CSS you suggested hence, making my code shorter. Nice observation though.

  0

  

  Luka Glonti•3,440

  @lack21Posted over 1 year ago

  @Bibiwei-Pere Check screen size 810 x 1080 or iPad iPadOS 14.7.1 and you'll see the difference

  Marked as helpful

  0

  

  Bibiwei Pere•490

  @Bibiwei-PerePosted over 1 year ago

  @lack21 I just checked and I saw the difference I'll update it. Thanks for sharing. Let's connect on GitHub Chief 👍

  1