Sunnyside agency landing page

Community feedback

• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job Maciej

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container. For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc . But use header tag only once in main heading element.

  -> <li> <div class="contact-box"> <a class="contact-a" href="#">Contact</a> </div> </li> why you used a div here?

  Keep up the good work!

  Marked as helpful

  0
• 

  Aadvik•1,250

  @Aadv1kPosted almost 3 years ago

  It appears your logo is messed up, i actually faced the same issue and I fixed it like so

  .logo {
    width: 100px;
    height: fit-content;
  }
  

  Which might not be the greatest solution, but hey it works. Also your fonts aren't working.

  Marked as helpful

  0
• 

  Maciej•280

  @dreamspicePosted almost 3 years ago

  Hi, thank you for reply.

  Mmmm...

  U use this div because i can't add white padding for text but i can do it now.

  Ok, then this <h1>We are creative</h1> item should be outside this div?

  <header> <h1>...</h1> </header>

  not

  <header> <div class="header-text> <h1>..</h1> </div> </header>

  0
• 

  Maciej•280

  @dreamspicePosted almost 3 years ago

  I will check it later. Thank you.

  Font's for <p>, <a> doesn't work because i forgot to import font-weight: 400, in style guide i found only 600 / 700, 900.

  0