Design comparison
Solution retrospective
Hi,
I thing this looks good. I gave up with that hamburger menu but i will try do it.
I tried first time "mobile first" concept and it's great!
Have a nice day :)
Community feedback
- @NaveenGumastePosted over 2 years ago
Hay ! Good Job Maciej
These below mentioned tricks will help you remove any Accessibility Issues
-> Add
Main
tag after body like it should be your container. For 1st heading orh1
tag, use header tag and then inside the header put yourh1
orh2
etc . But use header tag only once in main heading element.->
<li> <div class="contact-box"> <a class="contact-a" href="#">Contact</a> </div> </li>
why you used a div here?Keep up the good work!
Marked as helpful0 - @Aadv1kPosted over 2 years ago
It appears your logo is messed up, i actually faced the same issue and I fixed it like so
.logo { width: 100px; height: fit-content; }
Which might not be the greatest solution, but hey it works. Also your fonts aren't working.
Marked as helpful0 - @dreamspicePosted over 2 years ago
Hi, thank you for reply.
Mmmm...
U use this div because i can't add white padding for text but i can do it now.
Ok, then this <h1>We are creative</h1> item should be outside this div?
<header> <h1>...</h1> </header>not
<header> <div class="header-text> <h1>..</h1> </div> </header>0 - @dreamspicePosted over 2 years ago
I will check it later. Thank you.
Font's for <p>, <a> doesn't work because i forgot to import font-weight: 400, in style guide i found only 600 / 700, 900.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord