Submitted over 2 years ago

Sunnyside Agency Landing Page

Sang Le• 520

@sqle157

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Agency landing page

HTML
CSS
JS

2junior

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hi,

This is my solution for this challenge! Any feedbacks are welcomed.

Happy coding!

Community feedback

Naveen Gumaste• 10,460

@NaveenGumaste

Posted over 2 years ago

Hay ! Sang Le Good Job on challenge

These below mentioned tricks will help you remove any Accessibility Issues

-> Always use h1 first and then h2, h3 and so on

-> Learn more on accessibility issues

If this comment helps you then pls mark it as helpful!

Have a good day and keep coding 👍!

Sang Le• 520

@sqle157

Posted over 2 years ago

@Crazimonk Thank you! I will take note of this

Chamu• 13,110

@ChamuMutezva

Posted over 2 years ago

Greetings Sang

Well done. The site looks good.

the hamburger should be an interactive element - a button to be precise. A div will a not be accessible when using a keyword.
look into responsive images (srcset and picture element) to display images between screen sizes

Sang Le• 520

@sqle157

Posted over 2 years ago

@ChamuMutezva Thank you! I was having a hard time changing picture between screen sizes, but now you give me the answer. I’m appreciated that

Jayson Agustin• 30

@jagustin08

Posted over 2 years ago

Hi Sang Le, you did a good job with this solution. Two things that I noticed immediately when I open your site are:

The background color of the text sections is a bit yellow-ish than the design.
There's a horizontal scroll, I think it's the 100vw that you set in your <body> tag that's causing it.

Other than that it's looks great. Good job!

Sang Le• 520

@sqle157

Posted over 2 years ago

@jagustin08 Thank you! I will take note of this for my next project

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord