Design comparison
Solution retrospective
Hi,
This is my solution for this challenge! Any feedbacks are welcomed.
Happy coding!
Community feedback
- @NaveenGumastePosted over 2 years ago
Hay ! Sang Le Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Always use h1 first and then h2, h3 and so on
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding š!
1 - @ChamuMutezvaPosted over 2 years ago
Greetings Sang
Well done. The site looks good.
- the hamburger should be an interactive element - a button to be precise. A div will a not be accessible when using a keyword.
- look into responsive images (srcset and picture element) to display images between screen sizes
1@sqle157Posted over 2 years ago@ChamuMutezva Thank you! I was having a hard time changing picture between screen sizes, but now you give me the answer. Iām appreciated that
0 - @jagustin08Posted over 2 years ago
Hi Sang Le, you did a good job with this solution. Two things that I noticed immediately when I open your site are:
- The background color of the text sections is a bit yellow-ish than the design.
- There's a horizontal scroll, I think it's the 100vw that you set in your <body> tag that's causing it.
Other than that it's looks great. Good job!
1@sqle157Posted over 2 years ago@jagustin08 Thank you! I will take note of this for my next project
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord