Design comparison
SolutionDesign
Community feedback
- @dwhensonPosted about 2 years ago
Hi Isaque803
Nice job here! Here's a few points you might like to consider:
- You could make the burger-menu element a
button
rather than adiv
. This will ensure that it can be opened by keyboard users. - Perhaps have a look at the
srcset
attribute? This will means you won't need to always load two images to allow for wide/narrow screens, which is much better for performance. - I think you need to put an accessible label on the svg icons at the bottom of the page? You could use
aria-label
(I think they should also be links?).
Otherwise nice job on this one!
Cheers Dave
Marked as helpful1 - You could make the burger-menu element a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord