Design comparison
Solution retrospective
Hello there! 👋
Thanks for checking out my project!
Feedbacks and suggestions are welcome!
Community feedback
- @elaineleungPosted over 2 years ago
Hi Paula, this is an amazing solution and pretty close to pixel perfect! I love the attention to detail, and my favorite parts are the animation in the menu interaction. I like how you've written your Sass and JS as well, just clean overall and easy to read.
I don't have much in terms of suggestions; the one thing I can think of is, in the gallery section, you can consider using image tags instead of background images in div tags because this is sort of like a showcase area, and so even for visually impaired users, there can be meaningful alt tag descriptions that can be of helpful when a screen reader is used. The
<picture>
element can be handy in this case for handling responsive images.Once again, great job, and looking forward to seeing more!
Marked as helpful0@paulaxisabelPosted over 2 years ago@elaineleung Hi, Elaine!
Thank you for your suggestions and comments! I really appreciate it.
I had no idea about the <picture> tag until now! Today I learned something new thanks to you. I'll definitely try it!
Thanks again!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord