Sunnyside landing page with react, typescript, and tailwind

Community feedback

• 

  Carlos Damian Perez•1,890

  @caarlosdamianPosted almost 2 years ago

  Hello, excellent work I liked your solution, I would like to give you some feedback

  1. Enclose your main content in a <main></main> tag
  2. Instead of having your application src/assests/componentets , I would suggest using src/sections , since they are sections and not components example of is a testimonial card.
  3. Since you use typescript try to be more descriptive in the name of the properties and add the type when you are making a map.
  4. Instead of just using <divs> try using <section> so it's more accessible
  5. Use .ts instead of tsx when you are not rendering HTML
  6. Will be better to store yout data in src/utils/data.ts not tsx since your not rendering html

  amazing work keep it up!!!

  Marked as helpful

  1

  ---

  

  ronaldlamdev•430

  @ronaldlamdevPosted almost 2 years ago

  @caarlosdamian thank you !!! :)

  0