Sunnyside Agency build with scss and React JS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello there, Farid Fawwaz Rakha Wibowo! 👋

  Nice job on this challenge! 👏 Your solution looks pretty good (I like the subtle transition of the mobile menu and the smooth-scroll you added). 👍 Also, kudos for trying out React! 😀

  I suggest,

  • Adding overflow-x: hidden to the body (or something similar) to prevent a horizontal scroll bar from appearing along the bottom of the page at certain screen widths.
  • Perhaps double-checking the file path to the favicon for the site (since it's not showing up, at the moment).
  • Making sure there is always some space between the navigation links in the header of the site (since the space between gets small and disappears when the width of the screen decreases in the desktop layout). 😉

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  1

  ---

  

  Farid Fawwaz Rakha Wibowo•285

  @Rakha112Posted over 3 years ago

  Hay @ApplePieGiraffe, thankyou for your feedback and suggestions, i'll try to double check and fix the favicon and spacing on nav link. And i have a question, is worth it to learning react js ? Thankyou so much :)

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  @Rakha112

  Glad to help! 😀

  I think learning a framework like React is good idea if you would like to improve your skills as a front-end developer. It's very helpful when building large, interactive projects where doing so with vanilla JS would be difficult and/or take a long time. I'd advise you to be a little comfortable with JS itself first, though, since that'll make learning and understanding React easier. 😉

  Another good framework (that I think is slightly easier than React to learn at first) is Svelte. It might be a good start if you're looking to dive into frameworks, soon. But React is far more popular, at the moment, so it's up to you which you decide to learn first or dive into. Good luck! 👍

  0

  

  Farid Fawwaz Rakha Wibowo•285

  @Rakha112Posted over 3 years ago

  @ApplePieGiraffe thankyou so much for your explanation :)

  0