Sunnyside Agency

Community feedback

• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  hi, At first glace everything looked okay. But i found some issues, i like to point out.

  • Its not fully responsive. You just desinged for two fixed size screen. For in-between sizes content touches the screen border. I would suggest to always have a wrapper around the main content. Here is what i do:

  <header>
    <div class="header-wrapper">
  
    </div>
  </header>
  

  .header-wrapper{
   width:90vw;
   max-width:1280px; // change this according to your need
   margin: 0 auto;
  }
  
  //Note- i take mobile-first approch
  @media(min-width:780px){
    .header-wrapper{
     padding: 0 1rem;
    }
  }
  

  • Hide the menu- item for large screen. Just to be safe.

  I have also completed this challege . Here is my solution

  https://sunnyside-fem.vercel.app/

  Do share your thoughts.

  Good Luck,

  Happy Coding

  0