Sunny card made with scss

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 11 months ago

  Hello @ExploryKod!

  Your solution looks excellent!

  I have just one suggestion:

  • Use main to wrap the main content instead of main and article.

  📌 The tag article would make more sense if the card was part of a bigger website (in certainly would in real world), but here it is all we have on the screen.

  This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  1

  ---

  

  Amaury Franssen•180

  @ExploryKodPosted 5 months ago

  @danielmrz-dev Thank you for your advice, indeed there is no need of section or article tags as this is a card left alone without any other context.

  1
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Greetings! you have done a great job 😎

  📌 Some suggestions

  • You can use the calc function on your min-height. From your 100vh you can subtract the height of your footer so that this vertical scroll is not caused. This would look like: min-height: calc(100vh - 11px)
  • You can add a margin-inline in your layout__card so that the card is not stuck to the edges on mobile screens
  • I leave you the task of researching the box-sizing: border-box

  Marked as helpful

  1

  ---

  

  Amaury Franssen•180

  @ExploryKodPosted 5 months ago

  Thanks @Blackpachamame 😎.

  Indeed these rules are lacking, thank for helping me improve the solution.

  1