Design comparison
SolutionDesign
Solution retrospective
Feedback appreciated.
Community feedback
- @ChamuMutezvaPosted about 3 years ago
- look into responsive images techniques, the method you used below works but is not the best practice - it wastes bandwidth and is also expensive as users are forced to download images that they don't use.
<div class="info-picture transform-picture"> <img class="egg-mobile" src="./images/mobile/image-transform.jpg" alt="Egg" /> <img class="egg-desktop" src="./images/desktop/image-transform.jpg" alt="Egg" /> </div>
- maybe the following image should be a decorative image , use
alt=""
for decorative images. If an image is decorative then your alt values should be descriptive to allow assistive technology users to visualize the message that is being put across.<img src="./images/icon-arrow-down.svg" alt="arrow down" />
. The message should is not only to tell the user of the presence of an arrow image but it has to do more with the content of the image - in this case i would leave this one as a decorative image. - your javascript is not loading with a
status 404
. Try changing putting a dot before the first slash - well done , site is reponsive
0@BarbelitosPosted about 3 years agoThanks a lot for your amazing feedback! I’ll have a look at these issues, you are giving me some great tips, really appreciate!
0 - @ounissi-zakariaPosted about 3 years ago
It looks good but it's a bit different from the original design. There is also some color mismatch, if you can get it fixed. Keep up the good work .
0@BarbelitosPosted about 3 years agoThanks a lot for the feedback! I’ll have a look at it!!
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord