summary-component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello Nanba 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100vw property for body is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • So feel free to remove width: 100vw style rule from body this will help you to write efficient code and makes your code more reusable.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0

  ---

  

  Arunkumar•210

  @apy1412Posted over 1 year ago

  thanks. I am aware of this.....I was testing something and forgot to remove it after I did it.@0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  @apy1412 Glad you found it helpful ! 🤠

  0
• 

  Amar Kosare•170

  @amar215Posted over 1 year ago

  Your CSS code looks well-structured and organized.

  Good use of CSS resets- The initial code block using *, *::after, and *::before to reset box sizing and margins is a good practice to ensure consistent rendering across different browsers.

  Consistent use of units- It seems you are using a mix of absolute (px) and relative (rem) units. It's generally recommended to use relative units for better scalability across different screen sizes and devices. Consider using relative units consistently throughout your code.

  Consider adding comments- While your code is relatively easy to read and understand, adding comments can further clarify the purpose of specific sections or styles, making it easier for others and your future self to maintain the code.

  The solution you posted was accurate. Happy Coding!

  0

  ---

  

  Arunkumar•210

  @apy1412Posted over 1 year ago

  thanks... noted@amar215

  0