Abdul Khaliq πβ’ 72,640
@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- Your solution generates accessibility error reports due to
non-semantic
markup
- So wrap the whole content with semantic element
<main>
and change<div class="attribution">
with element<footer>
to improve accessibility and organization of your page.
- Use HTML5 semantic elements such as
<header>
,<nav>
,<main>
,<aside>
, and<footer>
to define these sections
CSS π¨:
- To center the component in the page, you should use
Flexbox
orGrid
layout. You can read more about centering in CSS here π.
body {
min-height: 100vh;
display: grid;
place-content: center;
margin: 0;
}
I hope you find it helpful ! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful
0